Skip to content

fix: generation of memoized class member calls#982

Merged
lars-reimann merged 8 commits intomainfrom
fix-generation-member-class
Apr 3, 2024
Merged

fix: generation of memoized class member calls#982
lars-reimann merged 8 commits intomainfrom
fix-generation-member-class

Conversation

@WinPlay02
Copy link
Contributor

@WinPlay02 WinPlay02 commented Apr 3, 2024

  • fix: generating memoized class member calls (on non-static members) should still use the class for python code generation
  • added testcase

Fixes the (last) issue in #954

@github-actions
Copy link

github-actions bot commented Apr 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.05s
✅ TYPESCRIPT eslint 1 0 0 4.18s
✅ TYPESCRIPT prettier 1 0 0 0.99s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@WinPlay02 WinPlay02 marked this pull request as ready for review April 3, 2024 18:00
@WinPlay02 WinPlay02 requested a review from lars-reimann as a code owner April 3, 2024 18:00
@codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f69d836) to head (18238b0).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #982   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines        18025     18042   +17     
  Branches      3758      3764    +6     
=========================================
+ Hits         18025     18042   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WinPlay02 WinPlay02 requested a review from lars-reimann April 3, 2024 20:01
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you.

@lars-reimann lars-reimann merged commit ed06aef into main Apr 3, 2024
@lars-reimann lars-reimann deleted the fix-generation-member-class branch April 3, 2024 20:14
lars-reimann pushed a commit that referenced this pull request Apr 6, 2024
## [0.10.0](v0.9.0...v0.10.0) (2024-04-06)

### Features

* add settings to enable inlay hints individually ([#992](#992)) ([b0f3e62](b0f3e62))
* filter suggestions by node type ([#999](#999)) ([8d22e67](8d22e67)), closes [#998](#998)
* forbid instance and static class members with same name ([#988](#988)) ([7fa6fd4](7fa6fd4))
* improved completion provider ([#997](#997)) ([61e776b](61e776b)), closes [#41](#41)
* inlay hints for inferred types of lambda parameters ([#993](#993)) ([c064e0e](c064e0e))
* mark entire type cast as wrong if cast is impossible ([#991](#991)) ([72d4e2e](72d4e2e))
* profiling in EDA tool ([#954](#954)) ([854122c](854122c)), closes [#929](#929)
* require `safe-ds-runner>=0.8.0,<0.9.0` ([#976](#976)) ([1003e6c](1003e6c))
* resolve name paths in `{[@link](https://github.com/link) }` tags in documentation ([#978](#978)) ([b59d6f0](b59d6f0))

### Bug Fixes

* catch internal errors caused by wrong synthetic nodes created by completion provider ([#1001](#1001)) ([8a6ab99](8a6ab99))
* chained memoized calls ([#987](#987)) ([df89291](df89291))
* correctly import declarations for member functions ([#983](#983)) ([79f9b08](79f9b08))
* error in Python generator for assignments with class/enum variant call as RHS ([#977](#977)) ([46b2bb2](46b2bb2)), closes [#975](#975)
* generation of memoized class member calls ([#982](#982)) ([ed06aef](ed06aef))
* generation of Python imports ([#979](#979)) ([f69d836](f69d836)), closes [#974](#974)
* invalid Python code generated for constructor calls ([#981](#981)) ([c7d006f](c7d006f)), closes [#980](#980)
* Python generation for type casts ([#1000](#1000)) ([621ab86](621ab86))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants