Skip to content

Return new model when calling fit #69

@lars-reimann

Description

@lars-reimann

Is your feature request related to a problem?

Methods of data containers like Table always return a new data container. The fit method of models, however, mutates a model in place.

Desired solution

For the sake of consistency, we should consider whether fit should also return a new model. If we implement that, we should also think about differentiating between trained and untrained models. Only the latter should have a predict methods or methods for metrics (#64).

Possible names (likewise for regressors):

  • ClassifierDraft
  • ClassifierTemplate
  • ClassifierBlueprint
  • ClassifierPrototype - It's not quite a prototype though, since we don't just clone an instance when we fit. We also initialize weights etc. So that's not my favorite
  • ClassifierBuilder - We don't use the builder pattern though, values can only be set in the constructor. So that is not my favorite either.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

Metadata

Metadata

Assignees

Labels

releasedIncluded in a release

Type

No type

Projects

Status

✔️ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions