test: snapshot tests for diagrams by PhilipGutberlet · Pull Request #239 · Safe-DS/Library

PhilipGutberlet · 2023-04-21T14:45:27Z

Closes #175.

Summary of Changes

Created tests to check if there are any graphic changes in the seaborn library by adding legacy graphics to compare to

Co-authored-by: patrikguempel 128832338+patrikguempel@users.noreply.github.com

lars-reimann · 2023-04-21T14:47:15Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	5	0	0	0.57s
✅ PYTHON	mypy	5		0	1.36s
✅ PYTHON	ruff	5	0	0	0.04s
✅ REPOSITORY	git_diff	yes		no	0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

src/safeds/data/image/__init__.py

tests/resources/image/legacy_boxplot.png

- refactored file names of image snapshots

codecov · 2023-04-28T09:34:32Z

Codecov Report

Merging #239 (640a4b9) into main (d47aaab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          44       44           
  Lines        1580     1580           
=======================================
  Hits         1568     1568           
  Misses         12       12

tests/safeds/data/tabular/containers/_column/test_plot_boxplot.py

Co-authored-by: Lars Reimann <mail@larsreimann.com>

lars-reimann · 2023-04-28T11:05:59Z

Hint: Use the Rename refactoring to rename declarations. This way references also get updated.

…com/Safe-DS/Stdlib into 175-test-output-of-plotting-methods # Conflicts: # tests/safeds/data/tabular/containers/_column/test_plot_boxplot.py # tests/safeds/data/tabular/containers/_column/test_plot_histogram.py # tests/safeds/data/tabular/containers/_table/test_plot_lineplot.py # tests/safeds/data/tabular/containers/_table/test_plot_scatterplot.py

tests/safeds/data/tabular/containers/_column/test_plot_boxplot.py

tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py

tests/safeds/data/tabular/containers/_column/test_plot_histogram.py

lars-reimann · 2023-04-28T18:56:57Z

Please finish this next week before starting something new.

…l column in the table (#254) Closes #156. ### Summary of Changes Added `Table.plot_boxplots` to plot a boxplot for each numerical column in the table Changed `Column.plot_boxplot` to set the title instead of the xlabel to match `Table.plot_boxplots` ### Additional Context Waiting for #239 -> Needed to add tests for `Table.plot_boxplots` --------- Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com> Co-authored-by: alex-senger <91055000+alex-senger@users.noreply.github.com> Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com> Co-authored-by: Lars Reimann <mail@larsreimann.com>

## [0.12.0](v0.11.0...v0.12.0) (2023-05-11) ### Features * add `learning_rate` to AdaBoost classifier and regressor. ([#251](#251)) ([7f74440](7f74440)), closes [#167](#167) * add alpha parameter to `lasso_regression` ([#232](#232)) ([b5050b9](b5050b9)), closes [#163](#163) * add parameter `lasso_ratio` to `ElasticNetRegression` ([#237](#237)) ([4a1a736](4a1a736)), closes [#166](#166) * Add parameter `number_of_tree` to `RandomForest` classifier and regressor ([#230](#230)) ([414336a](414336a)), closes [#161](#161) * Added `Table.plot_boxplots` to plot a boxplot for each numerical column in the table ([#254](#254)) ([0203a0c](0203a0c)), closes [#156](#156) [#239](#239) * Added `Table.plot_histograms` to plot a histogram for each column in the table ([#252](#252)) ([e27d410](e27d410)), closes [#157](#157) * Added `Table.transform_table` method which returns the transformed Table ([#229](#229)) ([0a9ce72](0a9ce72)), closes [#110](#110) * Added alpha parameter to `RidgeRegression` ([#231](#231)) ([1ddc948](1ddc948)), closes [#164](#164) * Added Column#transform ([#270](#270)) ([40fb756](40fb756)), closes [#255](#255) * Added method `Table.inverse_transform_table` which returns the original table ([#227](#227)) ([846bf23](846bf23)), closes [#111](#111) * Added parameter `c` to `SupportVectorMachines` ([#267](#267)) ([a88eb8b](a88eb8b)), closes [#169](#169) * Added parameter `maximum_number_of_learner` and `learner` to `AdaBoost` ([#269](#269)) ([bb5a07e](bb5a07e)), closes [#171](#171) [#173](#173) * Added parameter `number_of_trees` to `GradientBoosting` ([#268](#268)) ([766f2ff](766f2ff)), closes [#170](#170) * Allow arguments of type pathlib.Path for file I/O methods ([#228](#228)) ([2b58c82](2b58c82)), closes [#146](#146) * convert `Schema` to `dict` and format it nicely in a notebook ([#244](#244)) ([ad1cac5](ad1cac5)), closes [#151](#151) * Convert between Excel file and `Table` ([#233](#233)) ([0d7a998](0d7a998)), closes [#138](#138) [#139](#139) * convert containers for tabular data to HTML ([#243](#243)) ([683c279](683c279)), closes [#140](#140) * make `Column` a subclass of `Sequence` ([#245](#245)) ([a35b943](a35b943)) * mark optional hyperparameters as keyword only ([#296](#296)) ([44a41eb](44a41eb)), closes [#278](#278) * move exceptions back to common package ([#295](#295)) ([a91172c](a91172c)), closes [#177](#177) [#262](#262) * precision metric for classification ([#272](#272)) ([5adadad](5adadad)), closes [#185](#185) * Raise error if an untagged table is used instead of a `TaggedTable` ([#234](#234)) ([8eea3dd](8eea3dd)), closes [#192](#192) * recall and F1-score metrics for classification ([#277](#277)) ([2cf93cc](2cf93cc)), closes [#187](#187) [#186](#186) * replace prefix `n` with `number_of` ([#250](#250)) ([f4f44a6](f4f44a6)), closes [#171](#171) * set `alpha` parameter for regularization of `ElasticNetRegression` ([#238](#238)) ([e642d1d](e642d1d)), closes [#165](#165) * Set `column_names` in `fit` methods of table transformers to be required ([#225](#225)) ([2856296](2856296)), closes [#179](#179) * set learning rate of Gradient Boosting models ([#253](#253)) ([9ffaf55](9ffaf55)), closes [#168](#168) * Support vector machine for regression and for classification ([#236](#236)) ([7f6c3bd](7f6c3bd)), closes [#154](#154) * usable constructor for `Table` ([#294](#294)) ([56a1fc4](56a1fc4)), closes [#266](#266) * usable constructor for `TaggedTable` ([#299](#299)) ([01c3ad9](01c3ad9)), closes [#293](#293) ### Bug Fixes * OneHotEncoder no longer creates duplicate column names ([#271](#271)) ([f604666](f604666)), closes [#201](#201) * selectively ignore one warning instead of all warnings ([#235](#235)) ([3aad07d](3aad07d))

lars-reimann · 2023-05-11T20:04:04Z

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

v0.12.0
GitHub release

Your semantic-release bot 📦🚀

legacy checks for boxplot, histogram, lineplot, scatterplot and heatmap

83a2285

PhilipGutberlet requested a review from a team as a code owner April 21, 2023 14:45

PhilipGutberlet linked an issue Apr 21, 2023 that may be closed by this pull request

Test output of plotting methods #175

Closed

lars-reimann reviewed Apr 21, 2023

View reviewed changes

src/safeds/data/image/__init__.py Outdated Show resolved Hide resolved

fixed positional argument error in test_plot_scatterplot_legacy_check()

0dcf2bf

lars-reimann changed the title ~~feat: Legacy checks tests for boxplot, histogram, lineplot, scatterplot and heatmap~~ feat: snapshot tests for diagrams Apr 28, 2023

lars-reimann changed the title ~~feat: snapshot tests for diagrams~~ test: snapshot tests for diagrams Apr 28, 2023

lars-reimann reviewed Apr 28, 2023

View reviewed changes

tests/resources/image/legacy_boxplot.png Show resolved Hide resolved

PhilipGutberlet and others added 3 commits April 28, 2023 11:25

- fixed image.png replacements

1ecd93b

- refactored file names of image snapshots

- fixed image.png replacements

39b7ae1

style: apply automated linter fixes

21381e5

lars-reimann requested changes Apr 28, 2023

View reviewed changes

lars-reimann and others added 3 commits April 28, 2023 11:38

Merge branch 'main' into 175-test-output-of-plotting-methods

0dc9caf

Update tests/safeds/data/tabular/containers/_column/test_plot_boxplot.py

a610617

Co-authored-by: Lars Reimann <mail@larsreimann.com>

Update tests/safeds/data/tabular/containers/_column/test_plot_boxplot.py

6e9f014

Co-authored-by: Lars Reimann <mail@larsreimann.com>

PhilipGutberlet and others added 3 commits April 28, 2023 13:16

removed out-commented code and replaced legacy with snapshot

4802a4c

style: apply automated linter fixes

65091fc

lars-reimann requested changes Apr 28, 2023

View reviewed changes

This was referenced Apr 28, 2023

feat: Added Table.plot_histograms to plot a histogram for each column in the table #252

Merged

feat: Added Table.plot_boxplots to plot a boxplot for each numerical column in the table #254

Merged

PhilipGutberlet and others added 5 commits May 5, 2023 09:27

remove one comment and removed the mokey tests

5e61944

style: apply automated linter fixes

6ccd205

update test names to test_should

11976bb

Merge branch 'main' into 175-test-output-of-plotting-methods

96af850

test: rename test methods

640a4b9

lars-reimann approved these changes May 5, 2023

View reviewed changes

lars-reimann merged commit 4bc4c09 into main May 5, 2023

lars-reimann deleted the 175-test-output-of-plotting-methods branch May 5, 2023 10:21

lars-reimann added the released Included in a release label May 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: snapshot tests for diagrams#239

test: snapshot tests for diagrams#239
lars-reimann merged 16 commits intomainfrom
175-test-output-of-plotting-methods

PhilipGutberlet commented Apr 21, 2023

Uh oh!

lars-reimann commented Apr 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 28, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lars-reimann commented Apr 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lars-reimann commented Apr 28, 2023

Uh oh!

lars-reimann commented May 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

PhilipGutberlet commented Apr 21, 2023

Summary of Changes

Uh oh!

lars-reimann commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lars-reimann commented Apr 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lars-reimann commented Apr 28, 2023

Uh oh!

lars-reimann commented May 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lars-reimann commented Apr 21, 2023 •

edited

Loading

codecov bot commented Apr 28, 2023 •

edited

Loading