Skip to content

feat: rename group_rows_by in Table to group_rows #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lars-reimann merged 1 commit into from
Apr 30, 2024
Merged

feat: rename group_rows_by in Table to group_rows #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/safeds/data/tabular/containers/_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@ def filter_rows(self, query: Callable[[Row], bool]) -> Table:

_T = TypeVar("_T")

def group_rows_by(self, key_selector: Callable[[Row], _T]) -> dict[_T, Table]:
def group_rows(self, key_selector: Callable[[Row], _T]) -> dict[_T, Table]:
"""
Return a dictionary with copies of the output tables as values and the keys from the key_selector.

Expand Down
2 changes: 1 addition & 1 deletion ...r/containers/_table/test_group_rows_by.py → ...ular/containers/_table/test_group_rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@
ids=["select by row1", "different types in column", "empty table", "table with no rows"],
)
def test_should_group_rows(table: Table, selector: Callable, expected: dict) -> None:
out = table.group_rows_by(selector)
out = table.group_rows(selector)
assert out == expected