Skip to content

fix: actually use kernel of support vector machines for training#681

Merged
lars-reimann merged 3 commits intomainfrom
602-svcsvr-kernel-and-degree-are-never-passed-to-scikit-learn
May 1, 2024
Merged

fix: actually use kernel of support vector machines for training#681
lars-reimann merged 3 commits intomainfrom
602-svcsvr-kernel-and-degree-are-never-passed-to-scikit-learn

Conversation

@lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 1, 2024

Closes #602

Summary of Changes

Previously, support vector machines always used an RBF kernel, regardless of the kernel requested by the user. This is fixed now.

@lars-reimann lars-reimann linked an issue May 1, 2024 that may be closed by this pull request
@lars-reimann lars-reimann changed the title fix: actually use kernel and degree of support vector machines for training fix: actually use kernel of support vector machines for training May 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 4 0 0 0.86s
✅ PYTHON mypy 4 0 2.27s
✅ PYTHON ruff 4 0 0 0.23s
✅ REPOSITORY git_diff yes no 0.25s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (db2b613) to head (92c7468).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #681   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        67           
  Lines         4824      4814   -10     
=========================================
- Hits          4824      4814   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review May 1, 2024 15:50
@lars-reimann lars-reimann requested a review from a team as a code owner May 1, 2024 15:50
@lars-reimann lars-reimann merged commit 09c5082 into main May 1, 2024
@lars-reimann lars-reimann deleted the 602-svcsvr-kernel-and-degree-are-never-passed-to-scikit-learn branch May 1, 2024 15:50
lars-reimann pushed a commit that referenced this pull request May 1, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-05-01)

### Features

* `is_fitted` is now always a property ([#662](#662)) ([b1db881](b1db881)), closes [#586](#586)
* add `Column.missing_value_count` ([#682](#682)) ([f084916](f084916)), closes [#642](#642)
* Add `InputConversion` & `OutputConversion` for nn interface ([#625](#625)) ([fd723f7](fd723f7)), closes [#621](#621)
* Add hash,eq and sizeof in ForwardLayer ([#634](#634)) ([72f7fde](72f7fde)), closes [#633](#633)
* allow using tables that already contain target for prediction ([#687](#687)) ([e9f1cfb](e9f1cfb)), closes [#636](#636)
* callback `Row.sort_columns` takes four parameters instead of two tuples ([#683](#683)) ([9c3e3de](9c3e3de)), closes [#584](#584)
* rename `group_rows_by` in `Table` to `group_rows` ([#661](#661)) ([c1644b7](c1644b7)), closes [#611](#611)
* rename `number_of_column` in `Row` to `number_of_columns` ([#660](#660)) ([0a08296](0a08296)), closes [#646](#646)
* rework `TaggedTable` ([#680](#680)) ([db2b613](db2b613)), closes [#647](#647)
* show missing value count/ratio in summarized statistics ([#684](#684)) ([74b8a35](74b8a35)), closes [#619](#619)
* specify `extras` instead of `features` in `to_tabular_dataset` ([#685](#685)) ([841657f](841657f)), closes [#623](#623)

### Bug Fixes

* actually use `kernel` of support vector machines for training ([#681](#681)) ([09c5082](09c5082)), closes [#602](#602)

### Performance Improvements

* Faster plot_histograms and more reliable plots ([#659](#659)) ([b5f0a12](b5f0a12))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVC/SVR kernel and degree are never passed to scikit-learn

1 participant