fix: 'Table.summarize_statistics()' fixed#777
Closed
SamanHushi wants to merge 3 commits intoSafe-DS:mainfrom
Closed
fix: 'Table.summarize_statistics()' fixed#777SamanHushi wants to merge 3 commits intoSafe-DS:mainfrom
SamanHushi wants to merge 3 commits intoSafe-DS:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 97.20% 97.21%
=======================================
Files 107 107
Lines 5519 5522 +3
=======================================
+ Hits 5365 5368 +3
Misses 154 154 ☔ View full report in Codecov by Sentry. |
SamanHushi
changed the title
|
|
||
| if type(non_missing.dtype)==pl.datatypes.Boolean: | ||
| non_missing = non_missing.cast(str) | ||
| mode_count = non_missing.unique_counts().max() |
Member
There was a problem hiding this comment.
non_missing.value_counts().get_column("count").max()
Seems to work for boolean as well, which saves us the conversion.
Member
|
Thanks I've included this in #778 and specified you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
cast the pl.series to str when its filled with bools when calculating variance.
This is needed because it can't get unique_counts from bools