feat: support placeholder queries that only request a subset of data#39
Merged
lars-reimann merged 15 commits intomainfrom Jan 24, 2024
Merged
feat: support placeholder queries that only request a subset of data#39lars-reimann merged 15 commits intomainfrom
lars-reimann merged 15 commits intomainfrom
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 390 421 +31
=========================================
+ Hits 390 421 +31 ☔ View full report in Codecov by Sentry. |
…DS/Runner into windowed-placeholder-query
…DS/Runner into windowed-placeholder-query
SmiteDeluxe
previously approved these changes
Jan 23, 2024
Contributor
SmiteDeluxe
left a comment
SmiteDeluxe
left a comment
There was a problem hiding this comment.
Looks good to me, although I am a bit out of touch with the runner anyway. The DSL changes are probably more relevant to me
lars-reimann
requested changes
Jan 23, 2024
…DS/Runner into windowed-placeholder-query # Conflicts: # src/safeds_runner/server/messages.py
lars-reimann
previously approved these changes
Jan 23, 2024
lars-reimann
approved these changes
Jan 24, 2024
lars-reimann
pushed a commit
that referenced
this pull request
Jan 26, 2024
## [0.5.0](v0.4.0...v0.5.0) (2024-01-26) ### Features * added json serializer that encodes tables and images ([#29](#29)) ([054cca4](054cca4)), closes [#20](#20) * Memoization ([#38](#38)) ([2a26b48](2a26b48)) * Replace flask with quart ([#43](#43)) ([5520b68](5520b68)), closes [#42](#42) * support placeholder queries that only request a subset of data ([#39](#39)) ([dae57dc](dae57dc)) * update to safe-ds 0.17.1 + server refactor ([#37](#37)) ([1bcad07](1bcad07)) ### Bug Fixes * allow multiple connections to work with the runner ([#31](#31)) ([64685a3](64685a3))
Member
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
placeholder_querymessages (VSCode to Runner) to allow optionalwindow_beginandwindow_sizefields (in addition to the placeholdername)placeholder_valuemessages (Runner to VSCode) to includewindow_begin,window_sizeandwindow_maxfields andwindowedflag when querying only windows of data