feat(plot_lines): use ordinal x-axis for integer tick labels#12
Merged
Conversation
Switch x-axis encoding from quantitative (Q) to ordinal (O) to guarantee integer-only tick labels. The x-axis represents a step/epoch index, making ordinal encoding semantically correct. Quantitative encoding with tickMinStep was stripped by vegafusion during Vega compilation. Also adds IPython cell markers (# %%) to test files for interactive visual verification in IDEs with ipykernel support. Each plot function can be visually inspected by running the corresponding cell. Build: adds ipykernel dev dependency for cell execution.
413eee5 to
d433dfe
Compare
npovejsil
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plot_linesx-axis from quantitative to ordinal encoding, ensuring integer-only tick labels for step/epoch indices# %%) to test files for interactive visual verificationDetails
The x-axis in
plot_linesrepresents discrete step indices. Quantitative encoding withtickMinStep=1was stripped during vegafusion compilation, causing fractional tick labels. Ordinal encoding is semantically correct for this use case and guarantees integer labels.The IPython cells allow each plot function to be visually verified by running cells directly in IDEs with ipykernel support.
Build
Adds
ipykerneldev dependency for cell execution.