Skip to content

Dev v1.4#326

Merged
jwildfire merged 14 commits intomasterfrom
dev-v1.4
Jun 18, 2021
Merged

Dev v1.4#326
jwildfire merged 14 commits intomasterfrom
dev-v1.4

Conversation

@jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Sep 3, 2020

Overview

This PR adds an nR ratio calculation to the hep-explorer and allows users to show r ratio and nR ratio on the x and y axis. Fixes #323.

Test Notes

We need to QC the nR ratio calculations before release via double programming using the data sets described below. General idea is to have a tester independently re-calculate participant-level nR ratio data and confirm that it matches the derived data in the tool. Would be good to do this in an R script, and perhaps save it in the `/test/ folder in this repo - like @samussiah did for pAlt here. See here for the nR ratio formula.

Three data sets can be downloaded for any version of the chart by clicking the "↓ Raw Data" button at the top of the page.

  • Initial data - This is the raw data that was loaded in to the tool. It is one record per person per measure per visit. To download, click the "↓ Raw Data" button with no keys pressed.
  • Derived data - This is the derived data that the tool uses to create the chart. It is one record per person. To download, click the "↓ Raw Data" button while holding the shift key.
  • Visit-level nR Ratio data - This is the visit-level nR ratio data as derived by the tool. It is one record per person per visit. The "value" colum has the nR ratio calculation at that time point. To download, click the "↓ Raw Data" button while holding the alt key.

@jwildfire jwildfire self-assigned this Dec 10, 2020
…odash-4.17.19

Bump lodash from 4.17.14 to 4.17.19
@jwildfire jwildfire requested a review from samussiah January 29, 2021 18:59
samussiah and others added 2 commits March 11, 2021 17:33
@jwildfire
Copy link
Contributor Author

jwildfire commented Jun 15, 2021

@samussiah Thanks for working on this a little while back. Would like to get this merged before the safetyGraphics v2 release. Do you remember where you left this? Any ideas on next steps?

@samussiah
Copy link
Contributor

@samussiah Thanks for working on this a little while back. Would like to get this merged before the safetyGraphics v2 release. Do you remember where you left this? Any ideas on next steps?

@jwildfire I basically reproduced every subject nR Ratio plot in R and compared them with the app... Let me double check the comparisons and get back to you. Do you have any suggestions on a more automated approach? Perhaps writing a little .js function that exposes the nR ratio calculations for comparison in R?

@jwildfire
Copy link
Contributor Author

Let me double check the comparisons and get back to you. Do you have any suggestions on a more automated approach? Perhaps writing a little .js function that exposes the nR ratio calculations for comparison in R?

I basically did this - from the test notes in the PR above:

Visit-level nR Ratio data - This is the visit-level nR ratio data as derived by the tool. It is one record per person per visit. The "value" colum has the nR ratio calculation at that time point. To download, click the "↓ Raw Data" button while holding the alt key.

So, seems like we could just pull that .csv, save it to your new validation folder and then do a quick compare.

@samussiah
Copy link
Contributor

I'll knock it out shortly.

Copy link
Contributor

@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Math looks good, nailed it!

…odash-4.17.21

Bump lodash from 4.17.14 to 4.17.21
@jwildfire jwildfire merged commit 43e1d3e into master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate addition of nR ratio

2 participants