Conversation
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.14...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
…odash-4.17.19 Bump lodash from 4.17.14 to 4.17.19
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.14...4.17.21) Signed-off-by: dependabot[bot] <support@github.com>
|
@samussiah Thanks for working on this a little while back. Would like to get this merged before the safetyGraphics v2 release. Do you remember where you left this? Any ideas on next steps? |
@jwildfire I basically reproduced every subject nR Ratio plot in R and compared them with the app... Let me double check the comparisons and get back to you. Do you have any suggestions on a more automated approach? Perhaps writing a little .js function that exposes the nR ratio calculations for comparison in R? |
I basically did this - from the test notes in the PR above:
So, seems like we could just pull that .csv, save it to your new validation folder and then do a quick compare. |
|
I'll knock it out shortly. |
…ck saves as file without extension
samussiah
left a comment
There was a problem hiding this comment.
Math looks good, nailed it!
…odash-4.17.21 Bump lodash from 4.17.14 to 4.17.21
Overview
This PR adds an nR ratio calculation to the hep-explorer and allows users to show r ratio and nR ratio on the x and y axis. Fixes #323.
Test Notes
We need to QC the nR ratio calculations before release via double programming using the data sets described below. General idea is to have a tester independently re-calculate participant-level nR ratio data and confirm that it matches the derived data in the tool. Would be good to do this in an R script, and perhaps save it in the `/test/ folder in this repo - like @samussiah did for pAlt here. See here for the nR ratio formula.
Three data sets can be downloaded for any version of the chart by clicking the "↓ Raw Data" button at the top of the page.