Skip to content

#136 move control of fold change labs in patient profile out of mappi…#146

Merged
Lovemore-Gakava merged 4 commits intodevfrom
136-migrate-foldchange-settings
Jun 13, 2024
Merged

#136 move control of fold change labs in patient profile out of mappi…#146
Lovemore-Gakava merged 4 commits intodevfrom
136-migrate-foldchange-settings

Conversation

@pburnsdata
Copy link
Contributor

@pburnsdata pburnsdata commented Jun 6, 2024

Issues

Closes #136

Let me know what y'all think about this solution/any ideas you have for improvements or alternatives. The example apps are under inst/ . An easy fix didn't seem obvious to me, but came up with this for now.

The Good

  • hides fold change measure values from mappings UI
  • allows for setting fold change measure values in metadata or in argument call
  • allows for interactive changing of fold change measure values in nepexplorer UI

The Bad

  • css hack
  • substring search based reference
  • requires user editing metadata file (maybe that's not bad tho..)

@pburnsdata pburnsdata marked this pull request as ready for review June 10, 2024 20:19
@Lovemore-Gakava Lovemore-Gakava merged commit 93af2db into dev Jun 13, 2024
@Lovemore-Gakava Lovemore-Gakava deleted the 136-migrate-foldchange-settings branch June 13, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants