Clearing the measure column setting causes the app to fail

[pburnsdata]

Deleting the measure column default setting causes the app to crash. It seems related to the fact that it is used in the field level settings.

Get following error:
Warning: Error in hasField: typeof(columnName) == "character" is not TRUE
71:

[jwildfire]

The hasField() check probably shouldn't even be running here since expected behavior should be for the linked measure_value options to be cleared when measure_col is deleted. Wondering if we lost or broke that observer during the refactor.

Seems like this only happens when measure_col is deleted (not when it is changed), so maybe the issue is just with the edge case where the input is cleared.

Assigning @bzkrouse to take an initial look.

[jwildfire]

Definitely something a bit weird going on:

• The bug doesn't occur if you change measure_col to a different variable before deleting it.
• There also appears to be a lag in the options for measure_values, if you change measure_col several times. The screenshot below shows measure_col set to PARAM, but field options populating from TRTP.

Odd ...

[bzkrouse]

Problematic code that is getting run when measure_col is cleared:
safetyGraphics:::hasField(fieldValue = "Bilirubin (umol/L)", columnName = NULL, data = adlbc)

I believe the issue is that validateSettings runs every time there is a change in settings, and the field level settings are filled in AFTER the column settings. So validateSettings gets run a couple of times and the order of observers isn't controlled enough. will keep digging!