clarify code section of html report #149#157
Merged
pburnsdata merged 3 commits intodev-v0.8.0from Feb 6, 2019
Merged
Conversation
Contributor
|
@pburnsdata Tweaked it a bit and approved. Look ok? |
jwildfire
approved these changes
Feb 6, 2019
Contributor
jwildfire
left a comment
jwildfire
left a comment
There was a problem hiding this comment.
👍
Minor tweaks committed.
bzkrouse
reviewed
Feb 6, 2019
| graphic_code <- bquote(eDISH(data = params$data, | ||
|
|
||
| writeLines("path <- 'path_to_data'") ### <-- Update this! | ||
| writeLines("my_data <- read.csv(file.path(path, 'data.csv'))") |
Contributor
There was a problem hiding this comment.
to your comment, we could make this line conditional on file extension - e.g. if sas7bdat file, then code could be ```my_data <- haven::read_sas(....)
Contributor
Author
There was a problem hiding this comment.
That's an awesome idea. I added #159 for this
bzkrouse
approved these changes
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#149
Part of me wonders if it should clarify that your data loading process will vary (just using csv as an example) but maybe that's obvious?