Merged
Conversation
pburnsdata
requested review from
bzkrouse and
jwildfire
and removed request for
jwildfire
bzkrouse
reviewed
Feb 7, 2019
| #' @param visitn_col Visit number variable name. Default: \code{"VISITN"}. | ||
| #' @param studyday_col Visit day variable name. Default: \code{"DY"}. | ||
| #' @param baseline An optional list defining which column \code{"value_col"} and values (one or more) \code{values} represent the baseline visit(s) of the study. | ||
| #' @param baseline An optional list defining which column (\code{value_col}) and \code{values} (one or more) represent the baseline visit(s) of the study. |
bzkrouse
approved these changes
Feb 7, 2019
Contributor
bzkrouse
left a comment
bzkrouse
left a comment
There was a problem hiding this comment.
Great catches and fixes!
jwildfire
approved these changes
Feb 7, 2019
Contributor
jwildfire
left a comment
jwildfire
left a comment
There was a problem hiding this comment.
💯 Looks great. Well done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#158
Was able to address all of these - but feel free to tweak
This is what the manual looks like now:
safetyGraphics-manual.pdf