Skip to content

update detectStandard#161

Merged
jwildfire merged 10 commits intodev-v0.8.0from
refactor-fields
Feb 7, 2019
Merged

update detectStandard#161
jwildfire merged 10 commits intodev-v0.8.0from
refactor-fields

Conversation

@jwildfire
Copy link
Copy Markdown
Contributor

#150

Thinking we might go ahead and merge this separately then tackle generateSettings() and validateSettings() in separate branches.

@jwildfire
Copy link
Copy Markdown
Contributor Author

image

App generally working ok, but column count needs a tweak. Might just tackle that later ...

@jwildfire jwildfire changed the base branch from master to dev-v0.8.0 February 6, 2019 22:55
@jwildfire jwildfire self-assigned this Feb 6, 2019
Copy link
Copy Markdown
Contributor

@pburnsdata pburnsdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, will need to pass checks and some clean up necessarily, but this is pretty awesome. Exciting to see fields showing up in detect standard :D Like the modularity and tests too

#'
#' @examples
#''
#' hasColumn(columnName="PARAM",data=adlbc) #TRUE
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will want to change out these examples

@jwildfire jwildfire merged commit a0efb37 into dev-v0.8.0 Feb 7, 2019
@jwildfire jwildfire deleted the refactor-fields branch February 7, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants