Merged
Conversation
pburnsdata
approved these changes
Feb 8, 2019
Contributor
pburnsdata
left a comment
pburnsdata
left a comment
There was a problem hiding this comment.
A lot cleaner and way more flexible. Nice work!
Imagine dataUpload.R will need some attention to fit the new format?
|
|
||
| settings<-list( | ||
| # build shell settings for each chart (move these to /data eventually?) | ||
| shells<-list() |
Contributor
There was a problem hiding this comment.
and maybe you only need to write the shell that matches the chart setting (so don't have to make a big list of them) - but that's not really a concern right now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update/refactor/simplify generate settings to deal with field level data mappings and prep for supporting multiple charts .
Closes #135 #151