Merged
Conversation
pburnsdata
approved these changes
Feb 11, 2019
Contributor
pburnsdata
left a comment
pburnsdata
left a comment
There was a problem hiding this comment.
Nice. Looks good to me! Less hacky and more modular
| #' safetyGraphics:::checkFieldSettings(fieldKey=fields,settings=testSettings, data=adlbc) | ||
| #' | ||
| #' @importFrom stringr str_split | ||
| #' @importFrom magrittr "%>%" |
Contributor
There was a problem hiding this comment.
may need to adjust dependencies
Contributor
Author
|
@pburnsdata @bzkrouse - Added #172 here. If one of you can take a look at the new commits, and then we can merge this tomorrow! There is a note regarding the use of |
pburnsdata
approved these changes
Feb 13, 2019
bzkrouse
reviewed
Feb 13, 2019
R/validateSettings.R
Outdated
|
|
||
| #valid=true if all checks pass, false otherwise | ||
| settingStatus$valid <- settingStatus$checkList%>%purrr::map_lgl(~.x[["valid"]])%>%all | ||
| settingStatus$valid <- settingStatus$checks%>%select(valid)%>%unlist%>%all |
Contributor
There was a problem hiding this comment.
I believe we will need this to clear notes:
select(.$valid) or select(.data$valid)
bzkrouse
reviewed
Feb 13, 2019
R/validateSettings.R
Outdated
| #create summary string | ||
| failCount <- settingStatus$checkList%>%purrr::map_dbl(~!.x[["valid"]])%>%sum | ||
| checkCount <- length(settingStatus$checkList) | ||
| failCount <- nrow(settingStatus$checks%>%filter(!valid)) |
Contributor
There was a problem hiding this comment.
filter(!.data$valid) or filter(!.$valid)
bzkrouse
approved these changes
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118 and #164 (but leaving #170 for later)