Remove library() calls in shiny app#178
Merged
bzkrouse merged 4 commits intodev-v0.8.0from Feb 15, 2019
Merged
Conversation
Contributor
Author
|
(you can ignore the first commit here, just snuck in from #177) |
pburnsdata
requested changes
Feb 14, 2019
| @@ -1,12 +1,3 @@ | |||
| # temporarily load deps | |||
| library(safetyGraphics) | |||
Contributor
There was a problem hiding this comment.
I think you would keep the library() calls, and that the source() calls removed previously were what was unnecessary
pburnsdata
requested changes
Feb 14, 2019
Contributor
Author
|
This all makes sense to me! @pburnsdata @bzkrouse I'm heading out shortly, but would one of you be willing to make the needed changes and get this merged to the dev branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to resolve #111, so dropped the various
library()calls in theglobal.RandUI.Rin the app. Now it's bombing though ... maybe namespace or description is off somehow? Or maybe we actually do need the library calls?@xni7 @pburnsdata @bzkrouse Thoughts?