Skip to content

Remove library() calls in shiny app#178

Merged
bzkrouse merged 4 commits intodev-v0.8.0from
no-library
Feb 15, 2019
Merged

Remove library() calls in shiny app#178
bzkrouse merged 4 commits intodev-v0.8.0from
no-library

Conversation

@jwildfire
Copy link
Copy Markdown
Contributor

Trying to resolve #111, so dropped the various library() calls in the global.R and UI.R in the app. Now it's bombing though ... maybe namespace or description is off somehow? Or maybe we actually do need the library calls?

install_github("ASA-DIA-InteractiveSafetyGraphics/safetyGraphics", ref = "no-library")
library(safetyGraphics)
safetyGraphicsApp()

@xni7 @pburnsdata @bzkrouse Thoughts?

@jwildfire
Copy link
Copy Markdown
Contributor Author

(you can ignore the first commit here, just snuck in from #177)

@jwildfire jwildfire changed the title No library Remove library() calls in shiny app Feb 13, 2019
@@ -1,12 +1,3 @@
# temporarily load deps
library(safetyGraphics)
Copy link
Copy Markdown
Contributor

@pburnsdata pburnsdata Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you would keep the library() calls, and that the source() calls removed previously were what was unnecessary

Copy link
Copy Markdown
Contributor

@pburnsdata pburnsdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that it's the source() calls we dropped before that were unnecessary not the library() calls and you can move any library() calls in ui.R inside global.R

@jwildfire
Copy link
Copy Markdown
Contributor Author

This all makes sense to me!

@pburnsdata @bzkrouse I'm heading out shortly, but would one of you be willing to make the needed changes and get this merged to the dev branch?

@bzkrouse bzkrouse requested a review from pburnsdata February 15, 2019 14:18
@bzkrouse bzkrouse merged commit 7f5cabb into dev-v0.8.0 Feb 15, 2019
@pburnsdata pburnsdata deleted the no-library branch February 15, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants