Merged
Conversation
bzkrouse
reviewed
Feb 14, 2019
R/trimData.R
Outdated
| if (!is.null(settings[['analysisFlag']][['value_col']])) { | ||
| data_subset %<>% | ||
| filter_at(settings[['analysisFlag']][['value_col']], all_vars(. %in% settings[['analysisFlag']][['values']])) | ||
| } |
Contributor
There was a problem hiding this comment.
I believe for the baseline values part, we don't necessarily want to restrict to ONLY baseline values. We just want to make sure they are included. So I think we want to filter on baseline flag OR analysis value.
Contributor
There was a problem hiding this comment.
agreed. something like:
data_subset %<>%
mutate(isBaseline = settings[['baseline']][['value_col']] %in% settings[['baseline']][["values]]) %>%
mutate(isAnly = settings[['analysisFlag']][['value_col']] %in% settings[['analysisFlag']][["values]]) %>%
filter(isBaseline || isAnly)
Contributor
There was a problem hiding this comment.
might need to throw some ifelse(is.null()) logic in those mutates too.
jwildfire
requested changes
Feb 14, 2019
| dataUpload <- function(input, output, session){ | ||
|
|
||
| ns <- session$ns | ||
| maxFileSize <- 20 |
Contributor
There was a problem hiding this comment.
I was thinking we'd handle this in safetyGraphicsApp(). That we could make maxFileSize a new option that the user can configure for a given session.
R/trimData.R
Outdated
|
|
||
| trimData <- function(data, settings){ | ||
|
|
||
| #remove columns not in settings |
bzkrouse
approved these changes
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#19