Skip to content

Update generateSettings.R#208

Merged
jwildfire merged 18 commits intodev-v0.10.0from
generate-settings-mockup
Mar 18, 2019
Merged

Update generateSettings.R#208
jwildfire merged 18 commits intodev-v0.10.0from
generate-settings-mockup

Conversation

@jwildfire
Copy link
Copy Markdown
Contributor

@jwildfire jwildfire commented Mar 8, 2019

close #199

@jwildfire
Copy link
Copy Markdown
Contributor Author

generateShell(charts){
#get settings that are relevant to (at least one of) the charts
getSettingsMetaData(charts=charts)

#loop through those settings and create a list with the proper structure

#fill in default values
}

@jwildfire jwildfire changed the base branch from master to dev-v0.10.0 March 13, 2019 14:57
Copy link
Copy Markdown
Contributor

@pburnsdata pburnsdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just from glancing over the code! I remember discussing custom values - would that just be a thought for later?

Copy link
Copy Markdown
Contributor

@pburnsdata pburnsdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes - this will definitely be much closer to a multichart solution

"warningText", "Caution: This interactive graphic is not validated. Any clinical recommendations based on this tool should be confirmed using your organizations standard operating procedures."
)

saveRDS(defaults, file="data-raw/defaults.rda")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pburnsdata did you try saveRDS() with a .rds file extension?

@jwildfire jwildfire merged commit a1803bd into dev-v0.10.0 Mar 18, 2019
@jwildfire jwildfire deleted the generate-settings-mockup branch March 28, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants