Skip to content

Update imports and documentation#451

Merged
jwildfire merged 2 commits intomodule-rendererfrom
update-imports-documentation
Dec 3, 2020
Merged

Update imports and documentation#451
jwildfire merged 2 commits intomodule-rendererfrom
update-imports-documentation

Conversation

@rescalan
Copy link
Contributor

@rescalan rescalan commented Dec 2, 2020

Fixes #450

I added {esquisse} manually to the Imports field in DESCRIPTION

All other updates are done automatically by devtools::document

I believe {Tendril}, {Tplyr}, {kableExtra} are needed as well but I couldn't find an explicit use of those packages by searching for the package name in the code so I haven't added them to the DESCRIPTION.

@rescalan rescalan requested a review from jwildfire December 2, 2020 16:22
@jwildfire jwildfire changed the base branch from dev to module-renderer December 3, 2020 11:42
@jwildfire jwildfire linked an issue Dec 3, 2020 that may be closed by this pull request
Copy link
Contributor

@jwildfire jwildfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. Changed base branch and merged.

@jwildfire jwildfire merged commit 1b12c36 into module-renderer Dec 3, 2020
@jwildfire jwildfire deleted the update-imports-documentation branch December 3, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing dependencies

2 participants