Conversation
elimillera
approved these changes
Feb 10, 2021
Contributor
elimillera
left a comment
elimillera
left a comment
There was a problem hiding this comment.
One comment in the DESCRIPTION but otherwise this looks great!
| person("James","Buchanan", role="aut"), | ||
| person("Susan","Duke", role="aut"), | ||
| person("Interactive Safety Graphics Working Group", role = "aut"), | ||
| person("Rho Inc.", role = "cph")) |
Contributor
There was a problem hiding this comment.
I believe we need to list the copyright holder from the LICENSE if its not going to be the maintainers. CRAN will reject a package if the copyright holder isn't noted in the description
Contributor
Author
There was a problem hiding this comment.
Thanks for the heads up, @elimillera. I filed #497 to deal with this before release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
Fixes #462 #488
Test notes
Make sure the app runs as expected and that all checks and tests pass locally.