Add chart ordering via YAML and fix DataTables issue in Participant Selector.#505
Merged
Add chart ordering via YAML and fix DataTables issue in Participant Selector.#505
Conversation
jwildfire
approved these changes
Apr 13, 2021
|
|
||
| charts <- charts[order(purrr::map_dbl(charts, function(chart) chart$order))] | ||
|
|
||
| names(charts) <- yaml_files %>% file_path_sans_ext %>% basename |
Contributor
There was a problem hiding this comment.
Probably need to call names() before order() since yaml_files isn't getting reordered. looks good otherwise!
Contributor
|
Merging - Looks good. Will test a bit before finalizing #494. |
Contributor
|
@samussiah @jwildfire this looks good. However, I will open a new issue as this will affect the "add a new chart" workflow #472. I think we can also add this to the RStudio add-in to allow users to sort the charts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the majority of
inst/htmlwidgets/lib(#506). Not sure why we still need theinst/htmlwidgetsfolder unless part of the UI ishtmlwidgets-driven.