Skip to content

Remove chart if order is negative#528

Merged
jwildfire merged 3 commits intodevfrom
fix-524
Apr 26, 2021
Merged

Remove chart if order is negative#528
jwildfire merged 3 commits intodevfrom
fix-524

Conversation

@jwildfire
Copy link
Contributor

Summary

Remove chart when order is negative. Fix #524

Test Notes

Set order to negative in a YAML files and make sure chart doesn't render.

@jwildfire jwildfire requested a review from xni7 April 21, 2021 17:37
@jwildfire jwildfire self-assigned this Apr 21, 2021
@jwildfire jwildfire mentioned this pull request Apr 22, 2021
@jwildfire jwildfire requested a review from elimillera April 26, 2021 03:04
Copy link
Contributor

@elimillera elimillera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested the ordering and confirmed a negative order doesn't appear in the list.

Dropped 1 charts: hepexplorer
To display these charts, set the `order` parameter in the chart object or yaml file to a positive number.

@jwildfire jwildfire merged commit f1928e1 into dev Apr 26, 2021
@jwildfire jwildfire deleted the fix-524 branch May 24, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't render chart when chart$order<0

2 participants