Skip to content

updated chart nav. fix #561 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwildfire merged 2 commits into from
Jun 16, 2021
Merged

updated chart nav. fix #561 #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57752c4
updated chart nav. fix #561
jwildfire Jun 15, 2021
c95ca77
remove stray devtools call
jwildfire Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/mod_chartsNav.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ chartsNav <- function(chart,ns){
inputId = "safetyGraphicsApp",
menuName = "Charts",
tab = tabPanel(
title = chart$label,
title = makeChartSummary(chart, showLinks=FALSE, class="chart-nav"),
value = chart$name,
chartsTabUI(
id=ns(chart$name),
Expand Down
20 changes: 20 additions & 0 deletions inst/www/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ table.metatable.dataTable tr > td:last-of-type, table.metatable.trdataTable tr >
margin-bottom: 1em;
}

/* Formatting for charts metadata on chart page headers */

.chart-header{
background: #e7e7e7;
Expand Down Expand Up @@ -85,6 +86,7 @@ table.metatable.dataTable tr > td:last-of-type, table.metatable.trdataTable tr >
padding-right:0.5em;
}

/* Formatting for charts items in init item sorter */
.chart-sortable{
font-size:0.8em;
}
Expand All @@ -102,3 +104,21 @@ table.metatable.dataTable tr > td:last-of-type, table.metatable.trdataTable tr >
color:#999;
}

/* Formatting for charts items in nav dropdown */
.chart-nav *{
display:inline-block;
}

.chart-nav div:not(:first-child){
font-size:0.8em;
color: #999;
}

.chart-nav div:last-child::before{
content: "/";
}

.chart-nav small{
display:none;
}

1 change: 0 additions & 1 deletion tests/testthat/module_examples/filterTab/app.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,5 +201,4 @@ server <- function(input,output,session){
}

#options(shiny.reactlog = TRUE)
devtools::load_all()
shinyApp(ui, server)