Conversation
samussiah
left a comment
samussiah
left a comment
There was a problem hiding this comment.
Spinner locks the app when export fails.
| params = params, ## pass in params | ||
| envir = new.env(parent = globalenv()) ## eval in child of global env | ||
| ) | ||
| remove_modal_spinner() # remove it when done |
There was a problem hiding this comment.
This line doesn't run if report fails - Demographics Table, Shift Table - and spinner just spins.
There was a problem hiding this comment.
Can we just drop these two modules for this release? They don't work on my workstation.
There was a problem hiding this comment.
Yeah, Shift Table is no longer in the default build after SafetyGraphics/safetyCharts#67, demographics table is exporting for me, but it's just printing the R object (screenshot below). The download RTF button on the chart page is the real "export" workflow for now. So, I think we should just set the export flag to false for it for now. Filed SafetyGraphics/safetyCharts#70 to deal with that in safetyCharts.
We should probably discuss that workflow a bit more with @elimillera at some point, but I think I'm ok waiting until after 2.0
There was a problem hiding this comment.
This line doesn't run if report fails - Demographics Table, Shift Table - and spinner just spins.
Yeah, I'm not sure the best workflow here. I guess at the very least we should have some trycatch() logic that throws a decent message to the modal if the export fails.
I think I'm going to leave #517 for a different PR that deals with some of the other issues in the export. I'll close this one, and make a new PR that just resolves #576.
2 participants
Overview
Added 2 types of loading indicators using
shinybusy:Fix #576. Fix #519.
Test notes
Make sure the new loading indicators are working as expected and don't have any major unintended consequences ...