Skip to content

Improve init#601

Merged
jwildfire merged 7 commits intodevfrom
improveInit
Aug 6, 2021
Merged

Improve init#601
jwildfire merged 7 commits intodevfrom
improveInit

Conversation

@jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Aug 6, 2021

Overview

Usability improvements in safetyGraphicsInit().

Fixes #570 #569 #600

Details

Adds/fixes the following functionality
- #570
- #569
- Don't wipe loaded data when charts change ...
- Add instructions

Test Notes

Run safetyGraphicsInit() and make sure you can select charts, load data and initialize the app. Chart order in the app should match the order in the sortable list.

@jwildfire jwildfire self-assigned this Aug 6, 2021
@elimillera
Copy link
Contributor

Working great for me. It was breaking because I still had the old safetyCharts package installed, but updating to the latest version fixed that issue.

@xni7
Copy link
Contributor

xni7 commented Aug 6, 2021

93bad99 Looks nice. minor comments:

  • after dragging a few charts to the right Inactive Charts box, Select All button won't work anymore. Is it expected behavior?
  • secondly i selected 3 charts randomly but unable to initialize as seen below

By the way I have a conflict at 11 and sorry to have to skip the V2 call today

image

@jwildfire
Copy link
Contributor Author

  • after dragging a few charts to the right Inactive Charts box, Select All button won't work anymore. Is it expected behavior?

Hmm, I'm able to reproduce, but not sure why this is is happening. Some kind of issue with the reactivity/observers. I'm able to get the buttons to respond by clicking "Remove All" before "Select All", so might just let this slide and file an issue for later.

  • secondly i selected 3 charts randomly but unable to initialize as seen below

Good catch - this was a bug that pops up when not all of the domains are active. Fixed now.

@jwildfire
Copy link
Contributor Author

  • after dragging a few charts to the right Inactive Charts box, Select All button won't work anymore. Is it expected behavior?

@xni7 - I think this is fixed now too! Let me know if it's working for you.

@xni7
Copy link
Contributor

xni7 commented Aug 6, 2021

yeah, thanks @jwildfire ! The dragging issue is definitely fixed. The other issue also seems to have been fixed, except for the following shift table issue. I just selected one chart: the Shift Table but couldn't render

image

@jwildfire
Copy link
Contributor Author

Good deal. Shift Table is a renderer issue. I'll file something over in safetyCharts. Going to merge this now. Thanks for all the quick reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep sort order of charts in safetyGraphicsInit

3 participants