Skip to content

Update vignettes + pkgdown#665

Merged
jwildfire merged 3 commits intodevfrom
update-vignettes
Mar 28, 2022
Merged

Update vignettes + pkgdown#665
jwildfire merged 3 commits intodevfrom
update-vignettes

Conversation

@jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Mar 24, 2022

Overview

Syncs vignettes with the GitHub Wiki and re-runs pkgdown::build_site() for v2.1.

Fixes #634.

Test Notes

Open up docs/index.html and explore the pkgdown site.

@jwildfire jwildfire self-assigned this Mar 24, 2022
@jwildfire jwildfire requested review from elimillera and xni7 March 24, 2022 18:26
Copy link
Contributor

@xni7 xni7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. Good to learn about these pkgdown nuances. only comment is lowercase file name chartConfiguration.html is not matching the Capital letter ChartConfiguration.html. It doesn't matter for URLs, but did throw linux file system off 😃

- [Chart Configuration Vignette](ChartConfiguration.html) - details about the charting process including technical specifications and step-by-step instructions

@jwildfire jwildfire merged commit 123d425 into dev Mar 28, 2022
@jwildfire jwildfire deleted the update-vignettes branch March 28, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vignette links broken in pkgdown

2 participants