Conversation
add example display screenshot
issue #18 fixed by replacing all rbind with row_bind, made all date variables using as.Date.
Minor performance improvements
jwildfire
approved these changes
Aug 13, 2020
Contributor
jwildfire
left a comment
jwildfire
left a comment
There was a problem hiding this comment.
Looks great! Just made a few minor tweaks for now. Will look at more detail as I work in v0.2
| @@ -0,0 +1,77 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Filed an issue to convert this to the standard data flow used in packages in the next version. See #30.
| library(readr) | ||
| adae <- haven::read_xpt("https://github.com/phuse-org/phuse-scripts/raw/master/data/adam/cdisc/adae.xpt") %>% select(USUBJID, TRTEMFL, SAFFL) | ||
| adsl <- haven::read_xpt("https://github.com/phuse-org/phuse-scripts/raw/master/data/adam/cdisc/adsl.xpt") | ||
| ae = read_xpt("data/ae.xpt") %>% select(-STUDYID, -DOMAIN ) |
Contributor
There was a problem hiding this comment.
Looks good! Thanks for making this reproducible.
| } | ||
|
|
||
|
|
||
| ################################################################################ |
Contributor
There was a problem hiding this comment.
Just did a quick read here for now. Will dig in to the details as I sort out modularization in v0.2
Contributor
There was a problem hiding this comment.
Nice job simplifying the code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do:
You can test app by using the dataset here: https://github.com/SafetyGraphics/volcano-plot/blob/IZ_dev/data/test_data.csv