Make average GIF FPS approximately equal to lottie one#336
Open
ed-asriyan wants to merge 1 commit intoSamsung:masterfrom
ed-asriyan:patch-1
Open
Make average GIF FPS approximately equal to lottie one#336ed-asriyan wants to merge 1 commit intoSamsung:masterfrom ed-asriyan:patch-1
ed-asriyan wants to merge 1 commit intoSamsung:masterfrom
ed-asriyan:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today all frames in generated gifs have duration equal to 2, so 30 fps lottie animations converted to GIF looks faster that it should be. That PR solves this problem.
Each frame has duration approximately equal to one frame duration of lottie animation, so average GIF speed looks the same as a lottie.