add Allow user define RLOTTIE_API macros.#428
Open
mingkuang-Chuyu wants to merge 1 commit intoSamsung:masterfrom
Open
add Allow user define RLOTTIE_API macros.#428mingkuang-Chuyu wants to merge 1 commit intoSamsung:masterfrom
mingkuang-Chuyu wants to merge 1 commit intoSamsung:masterfrom
Conversation
hermet
requested changes
Sep 23, 2020
Member
hermet
left a comment
There was a problem hiding this comment.
Could you please explain which scenario requires this define?
The scenario that requires this define is being able to compile rlottie as a static library such that you can define RLOTTIE_API and avoid the dllimport on Windows. The alternative would be introduce a separate define for that such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can compile the static library by defining the RLOTTIE_API macro.
: )
Best
mingkuang