Skip to content

oversight: whilst output is on a single report (0x0), input is on separate reports. #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sapd merged 1 commit into from Dec 30, 2022
Merged

oversight: whilst output is on a single report (0x0), input is on separate reports. #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/devices/steelseries_arctis_9.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,16 @@ static int arctis_9_send_sidetone(hid_device* device_handle, uint8_t num)
return ret;
}

const unsigned char data_on[5] = { 0x0, 0x06, num };
const unsigned char data_off[3] = { 0x0, 0x06, 0xc0 };
const unsigned char data_on[5] = { 0x06, 0x0, num };
const unsigned char data_off[3] = { 0x06, 0x0, 0xc0 };

if (num) {
memmove(buf, data_on, sizeof(data_on));
} else {
memmove(buf, data_off, sizeof(data_off));
}

// TODO: Sometimes hangs.
ret = hid_write(device_handle, buf, 31);

free(buf);
Expand Down Expand Up @@ -106,8 +107,9 @@ static int arctis_9_send_inactive_time(hid_device* device_handle, uint8_t num)
{
// the value for the Arctis 9 needs to be in seconds
uint32_t time = num * 60;
uint8_t data[31] = { 0x0, 0x04, (uint8_t)(time >> 8), (uint8_t)(time) };
uint8_t data[31] = { 0x04, 0x0, (uint8_t)(time >> 8), (uint8_t)(time) };

// TODO: Sometimes hangs.
int ret = hid_write(device_handle, data, 31);

if (ret >= 0) {
Expand Down Expand Up @@ -137,7 +139,7 @@ static int arctis_9_request_chatmix(hid_device* device_handle)

int arctis_9_save_state(hid_device* device_handle)
{
uint8_t data[31] = { 0x0, 0x90 };
uint8_t data[31] = { 0x90, 0x0 };

return hid_write(device_handle, data, 31);
}
Expand Down