Fix: Remove double scrollbar in chat page Jules#218
Open
SaravanakumarR2018 wants to merge 1 commit into
Open
Conversation
The chat page previously exhibited two scrollbars when the chat history was extensive. This was due to an inner scrollable container with a fixed height and an `overflow-y-auto` style, nested within another container that also managed page scroll. This commit resolves the issue by: 1. Removing `overflow-y-auto` from the inner chat message container in `src/frontend/src/components/Chat.tsx`. 2. Removing the fixed height (`h-[calc(100vh-64px)]`) from the main parent `div` in `src/frontend/src/components/Chat.tsx`. These changes allow the chat content to naturally expand the height of its container, relying on the main browser window's scrollbar for navigation. The chat input bar remains sticky at the bottom of the viewport. End-to-end tests, including visual regression checks, have passed, confirming the fix and the absence of regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat page previously exhibited two scrollbars when the chat history was extensive. This was due to an inner scrollable container with a fixed height and an
overflow-y-autostyle, nested within another container that also managed page scroll.This commit resolves the issue by:
overflow-y-autofrom the inner chat message container insrc/frontend/src/components/Chat.tsx.h-[calc(100vh-64px)]) from the main parentdivinsrc/frontend/src/components/Chat.tsx.These changes allow the chat content to naturally expand the height of its container, relying on the main browser window's scrollbar for navigation. The chat input bar remains sticky at the bottom of the viewport.
End-to-end tests, including visual regression checks, have passed, confirming the fix and the absence of regressions.