Skip to content

Unit parsing#83

Merged
jamescrake-merani merged 66 commits intorefactor_24from
unit_parsing
Oct 1, 2024
Merged

Unit parsing#83
jamescrake-merani merged 66 commits intorefactor_24from
unit_parsing

Conversation

@jamescrake-merani
Copy link
Contributor

@jamescrake-merani jamescrake-merani commented Oct 1, 2024

No description provided.

James Crake-Merani added 30 commits September 11, 2024 09:07
Added some code to enable test driven development.
b206b03
Some minor changes to stop my editor from crying.
194fd5c 
Can probably revert back later.
Pass in the dimensions so this code is correct.
4463584
Wrote some tests ahead.
ffea2d6 
Enables some test driven development.
Parse using a slant as well.
6a72ac6
Found a regex for splitting up the string.
5788a82
Implemented the parse_single_unit function.
ad251e5
Use two functions for parsing.
92b076a
Use list comprehension to get potential symbols.
7159ca2
parse unit strs function.
2e38eb5
Created a function to pass in a stack of units.
c19f655
Multiply dimensions function.
0a9cac2
Use the new multiply function.
09d0b8d
Nvm I'm blind; there already was a multiply method.
355b8d5
Parse in a whole unit.
6bf37fa
I still need this multply for parse_unit_stack.
938db13 
Since the implementation in Lucas' code is just added the dimensions
together which isn't what I'm looking for here.
System for combining units.
9d20353 
Very dodgy.
Removed not implemented comment.
69e9310
Parse in a named unit.
5ddd1bd
Avoid mutating state.
eae52d0
Replace the unit on the stack.
7d3840b
Fixed the logic around combining units.
e8a2d3b
Parse_name_unit can take in an already parsed unit.
99f4f81
Added a todo comment.
bd3dfe8
Take a unit from the command line.
8a9d701
Added whitespace on input.
1c773e0
Fixed typo.
a7bbba5
Only multiply scale by 1, or -1.
05c3c02
Look for slashes in the string.
947f103
Got fraction units working as well :)
a1b6288
James Crake-Merani and others added 28 commits September 19, 2024 15:02
Catch key errors.
b8ff6be 
These will happen when we try to parse a unit that doesn't exist.
Expand the try block.
1f11030
Removed an old todo comment.
a5d71de
New unit test in pytest.
98fed84
Raise an exception if the unit can't be parsed.
ade0bb4
Added some unit tests that should error.
b313f4c
Created a regex validator for the unit str.
3808653
Throw an exception if the validation fails.
25f3903
Update unit test to reflect new error.
0920a66
Unit test for what I was originally testing for.
0148f27
Added more tests for slants.
06a0c9c
Slants should be valid unit strings as well.
067929f
Parse in newton as its defined value.
98bfc0c
Remove the old testing file.
8515a59
This function isn't being used.
ded94f2
Added to the doc string about unit groups.
3acb6e3
Moved the unit group to first.
5a45950 
This is probably better as I think the caller is more likely to use
longest_unit's default value when unit_group is set.
Small rename.
606eea3
Use destructuring to make this a bit cleaner.
0d272a7
Fixed function call.
d2abf95
Added some docstrings.
eb8a1ec
Refactored parse named unit so it just takes one arg.
46bbc44
Removed old todo comment.
8c1b984
Added some docstrings.
8c263b8
Stop linter from moaning.
556500e
Accept spaces in the unit str.
c8929c7
Split by dots as well.
5f00767
@jamescrake-merani
Merge branch 'refactor_24' into unit_parsing
544f131
@jamescrake-merani jamescrake-merani merged commit b000b38 into refactor_24 Oct 1, 2024
@jamescrake-merani jamescrake-merani deleted the unit_parsing branch October 1, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jamescrake-merani