feat(stability): refine timing to ensure numerical stability of performance measurements #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi developers @simonguozirui @anneouyang ,
Thanks for such a great project! We found numerical stability issue of kernel performance measurements in real world use case.
For small kernels, the returned list of forward elapsed times typically varies a lot (usually due to kernel launch overhead), and an outlier can greatly affect the mean or median timing. Even small deviation in kernel runtime will affect the benchmark result and reward in RL scenarios.
So, we need to guarantee numerical stability of performance measurements.
Therefore, we assume that a certain proportion of data points in multiple measurements are outliers, and by removing them from the list, we can obtain stable performance measurements.