Skip to content

V0.2.3#70

Merged
FL03 merged 19 commits intomainfrom
v0.2.3
Sep 22, 2024
Merged

V0.2.3#70
FL03 merged 19 commits intomainfrom
v0.2.3

Conversation

@FL03
Copy link
Copy Markdown
Member

@FL03 FL03 commented May 11, 2024

No description provided.

Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
@FL03 FL03 added bug Something isn't working enhancement New feature or request rust Improvements or additions that update the Rust code dependencies Pull requests that update a dependency file labels May 11, 2024
@FL03 FL03 added this to the v0.2.3 milestone May 11, 2024
@FL03 FL03 self-assigned this May 11, 2024
@FL03 FL03 added the github_actions Pull requests that update GitHub Actions code label May 11, 2024
FL03 added 2 commits May 12, 2024 08:54
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
FL03 added 2 commits May 24, 2024 03:39
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
FL03 added 2 commits May 28, 2024 02:01
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
@FL03 FL03 linked an issue May 29, 2024 that may be closed by this pull request
FL03 added 8 commits July 13, 2024 08:22
Signed-off-by: Joe McCain III <jo3mccain@icloud.com>
Signed-off-by: FL03 <jo3mccain@icloud.com>
Signed-off-by: FL03 <jo3mccain@icloud.com>
Signed-off-by: FL03 <jo3mccain@icloud.com>
Signed-off-by: FL03 <jo3mccain@icloud.com>
FL03 and others added 3 commits September 22, 2024 12:17
Signed-off-by: FL03 <jo3mccain@icloud.com>
Signed-off-by: FL03 <jo3mccain@icloud.com>
@FL03 FL03 marked this pull request as ready for review September 22, 2024 17:27
Comment thread core/src/errors/mod.rs
//! # Errors
//!
//!
#![cfg(feature = "alloc")]

Check warning

Code scanning / clippy

duplicated attribute

duplicated attribute
Comment thread core/src/time/mod.rs
pub use super::Now;
}

///

Check warning

Code scanning / clippy

empty doc comment

empty doc comment
Comment on lines +27 to +29
pub fn as_ref(&self) -> &T {
&self.0
}

Check warning

Code scanning / clippy

method `as_ref` can be confused for the standard trait method `std::convert::AsRef::as_ref`

method `as_ref` can be confused for the standard trait method `std::convert::AsRef::as_ref`
Comment on lines +31 to +33
pub fn as_mut(&mut self) -> &mut T {
&mut self.0
}

Check warning

Code scanning / clippy

method `as_mut` can be confused for the standard trait method `std::convert::AsMut::as_mut`

method `as_mut` can be confused for the standard trait method `std::convert::AsMut::as_mut`
Comment thread core/src/utils/std.rs
Appellation: std_utils <module>
Contrib: FL03 <jo3mccain@icloud.com>
*/
#![cfg(feature = "std")]

Check warning

Code scanning / clippy

duplicated attribute

duplicated attribute
Comment thread core/src/utils/std.rs
pub fn file_to_vec(fp: String) -> Result<Vec<String>, io::Error> {
let file_in = File::open(fp)?;
let file_reader = BufReader::new(file_in);
Ok(file_reader.lines().filter_map(Result::ok).collect())

Check warning

Code scanning / clippy

`filter_map()` will run forever if the iterator repeatedly produces an `Err`

`filter_map()` will run forever if the iterator repeatedly produces an `Err`
Signed-off-by: FL03 <jo3mccain@icloud.com>
@FL03 FL03 merged commit 88b828a into main Sep 22, 2024
@FL03 FL03 deleted the v0.2.3 branch September 22, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request github_actions Pull requests that update GitHub Actions code rust Improvements or additions that update the Rust code

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Rename the Toggle trait to TypeTag

2 participants