Skip to content

Conversation

@toqduj
Copy link
Collaborator

@toqduj toqduj commented Jul 5, 2023

The option "startPath" has been added to scientific_metadata in case you don't want the entire tree from "/" to be ingested. This can be helpful, for example, when you are storing raw, processed and analysed data in a single file and only want to catalog the analysis.

Copy link

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea

@bpedersen2
Copy link

probably a rebase


def scientific_metadata(
filename, excludeRootEntry: bool = True, skipKeyList: list = []
filename, excludeRootEntry: bool = True, skipKeyList: list = [], startPath:str="/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 is probably going to want spaces around the =

@dylanmcreynolds
Copy link
Member

Tests are failing on this. Is this something you still want to work on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants