Make lastindex(::AbstractVectorOfArray, i) error when i!=1#267
Closed
oscardssmith wants to merge 5 commits intoSciML:masterfrom
Closed
Make lastindex(::AbstractVectorOfArray, i) error when i!=1#267oscardssmith wants to merge 5 commits intoSciML:masterfrom
lastindex(::AbstractVectorOfArray, i) error when i!=1#267oscardssmith wants to merge 5 commits intoSciML:masterfrom
Conversation
6df1fc7 to
c933e3a
Compare
555075f to
4d8559a
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
A[:, end]error for raggedAbstractVectorOfArraywhen the lengths are not equal. Before it could either index out of bounds or get non-last indices.