Make RaggedEnd and RaggedRange broadcast as scalars#510
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Dec 22, 2025
Merged
Conversation
This fixes an issue where using `end` indexing with ragged arrays in SymbolicIndexingInterface would fail because `RaggedEnd` was being treated as an iterable in broadcasting contexts, causing `collect` to be called which requires `length`. By defining `Base.broadcastable(x::RaggedEnd) = Ref(x)` (and similarly for `RaggedRange`), these types are now treated as scalars in broadcasting operations, similar to how `Symbol` and `String` work. Fixes ModelingToolkit changeofvariables test failure: MethodError: no method matching length(::RecursiveArrayTools.RaggedEnd) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base.broadcastable(x::RaggedEnd) = Ref(x)andBase.broadcastable(x::RaggedRange) = Ref(x)to make these types broadcast as scalarsProblem
When using
endindexing with ragged arrays in SymbolicIndexingInterface (e.g.,sol[x[1], end]), broadcasting overRaggedEndfails because Julia's broadcast machinery tries tocollectit, which requireslength:Stack trace from ModelingToolkit CI:
Solution
By defining
Base.broadcastable(x::RaggedEnd) = Ref(x), these types are now treated as scalars in broadcasting operations - similar to howSymbol,String, and other non-collection types work. This is semantically correct sinceRaggedEndrepresents a single index value, not a collection.Test plan
RaggedEndandRaggedRangereturnReffrombroadcastableidentity.(ragged_idx)works without error🤖 Generated with Claude Code