Fix zeromatrix to preserve GPU array types for ArrayPartition#520
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Jan 8, 2026
Merged
Conversation
The previous implementation used `reduce(vcat, vec.(A.x))` which could cause type conversion issues with GPU arrays, leading to scalar indexing errors when using implicit ODE solvers with ArrayPartition of CuArrays. The fix uses `foldl` with an explicit `init` value from the first element of the tuple, ensuring the result array type matches the input type. This preserves GPU array types (CuArray, MtlArray, etc.) when building the zero matrix. Fixes SciML#496 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
CI Status SummaryPassing (18/28)✅ All core RecursiveArrayTools tests pass:
✅ All key downstream packages pass:
✅ Other checks:
Failing (likely pre-existing issues)❌ Julia pre-release tests (transient/expected failures):
❌ SciMLSensitivity downstream tests:
❌ Still Pending⏳ The core functionality change (using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #496 - Solving ODE using ArrayPartition of GPUArrays fails for implicit solvers
The issue was that the
zeromatrixfunction usedreduce(vcat, vec.(A.x))which could cause type conversion issues with GPU arrays, leading to scalar indexing errors when using implicit ODE solvers with ArrayPartition containing CuArrays or MtlArrays.Changes
ArrayInterface.zeromatrix(A::ArrayPartition)to usefoldlwith an explicitinitvalue from the first element, ensuring the result array type matches the input typeArrayInterface.zeromatrix(A::NamedArrayPartition)Root Cause
When
reduce(vcat, vec.(A.x))was called with GPU arrays, thereduceoperation could create an intermediate CPU array which then caused scalar indexing errors when OrdinaryDiffEq tried to build the Jacobian for implicit solvers.The fix uses
foldl(vcat, rest; init = vecs[1])which preserves the GPU array type by starting from the first GPU array element and concatenating subsequent elements onto it.Test Plan
zeromatrixcc @ChrisRackauckas
🤖 Generated with Claude Code