Achieve type stability for indexing by avoiding variable boxing, including for ranges#530
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Jan 22, 2026
Merged
Conversation
Ickaser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Following on from #525 , I realized that #526 didn't fix anything for ranges e.g.
vec[1, 1:end](which is the indexing I actually used), and having taken a look at Cthulhu output I could tell something was off in the indexing since there were lots of boxed variables.Eventually I worked out that the boxes were not due to closures, but due to variables being defined differently in different branches within the same scope. So I broke up the branches across a couple different functions, and that was enough to fix inference.
I am not committed to the names of any of these functions necessarily, and there may be some other improvements possible to avoid repeating the same code (the AI generated a lot of repetitive code).