Expose DecodeSpecialTokens through IInferenceParams for StatelessExecutor#1203
Merged
martindevans merged 1 commit intoSciSharp:masterfrom Jun 11, 2025
Conversation
…here applicable. Use the new property in StatelessExecutor
jacob-mink-1996
force-pushed
the
enable-executor-specify-decode-special-tokens
branch
from
b6c3097 to
596d511
Compare
Contributor
|
@martindevans - thanks for the direction on this. (and apologies for the account confusion in here - had to get my GPGs all in order). |
Contributor
|
Hey @martindevans just following up, is there anything else needed from me here? |
Member
|
Nothing more required - I was waiting for the tests to pass last time and never checked back in. Thanks for the reminder 👍 |
This was referenced Dec 3, 2025
This was referenced Jan 16, 2026
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DecodeSpecialTokensproperty toIInferenceParams- implement it where applicable. Use the new property inStatelessExecutor.As far as I can tell, this meant changing
InferenceParams(Llama)InferenceOptions(LLama.Web)The only executor that was using the
StreamingTokenDecoderclass isStatelessExecutor- I suspect that means thatContext.Decodeis not susceptible to this issue, although I've not tried that since I don't have a non-stateless use case (yet).Fixes #1201