Add llama_cpp_commit to Vulkan build and remove double params#801
Merged
martindevans merged 1 commit intoSciSharp:masterfrom Jun 20, 2024
Merged
Add llama_cpp_commit to Vulkan build and remove double params#801martindevans merged 1 commit intoSciSharp:masterfrom
martindevans merged 1 commit intoSciSharp:masterfrom
Conversation
Member
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
llama_cpp_commitparam to the Vulkan build workflow, and cleans up some double params that were already present inCOMMON_DEFINE.Build action completed succesfully on my fork and binaries were tested locally (including running the unit tests) without issues:
https://github.com/m0nsky/LLamaSharp/actions/runs/9598690516
This fix is required before the upcoming binary update. After the next binary update, we can merge Vulkan support (#797) and the new CUDA12 paths (#800).