Merged
Conversation
…le switch due to Basemap version issue).
Member
Author
|
To see all image diffs: try this |
test_mapping
test_cmap: acceptable images (other images not committed)
test_quickplot: all images ok
test_plot image changes, all ok
test_traj: images ok
test_gribload: image ok
more ok images (plt and qplt)
Contributor
|
Two more pull requests added for this branch:
However, there are still two remaining image result failures in test_cmap_norm. |
remaining acceptable image changes
Contributor
|
Outstanding issues:
I suggest we merge this in so #67 can progress. When merging this, we need to make two new Iris issues for the failing tests:
|
Contributor
|
@pelson pelson changes ok and tested |
fixed failing cmap test results
bblay
added a commit
that referenced
this pull request
Sep 25, 2012
Tests now run with matplotlib 1.2.0 rc2
Member
|
@bblay - that's an awful lot of commits in the history. In future I believe we should consider squashing lengthy pull requests like these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extestspass with matplotlib 1.2 rc2. (with one obvious exception)Remaining tests probably preferable to do in bunches (of modules).