ENH: Added coordinate inversion functionality#1731
ENH: Added coordinate inversion functionality#1731cpelley wants to merge 1 commit intoSciTools:masterfrom
Conversation
|
Test failures not relating to the changes of this PR |
See #1730. |
There was a problem hiding this comment.
There's already a lat_lon_cube function in this module which does a very similar (albeit more limited) job. It'd be nicer if we could just extend lat_lon_cube.
|
If I reverse a dimension that also has a 1D AuxCoord describing it, will that be reversed too? And what about if there is a 2D AuxCoord overlapping the dimension, will it be reversed along the required axis? |
There was a problem hiding this comment.
This doesn't really do enough to warrant existing as a separate function.
Perhaps this is a good time to consider whether (NB. This is somewhat related to @bjlittle's upcoming "add-ons"/"extensions"/"incubator" repo.) |
|
Thank you for your interest in this @rhattersley
I very much agree.
I'm happy to hold off on this PR until the new repo appears and service this for that? |
At the moment, I still think the main Iris repo is the place for this routine. I just wanted @bjlittle to be aware of this discussion since it's a related topic. |
|
Nudge... is there still life in this PR? |
|
Hi @rhattersley thanks for prodding. Based on the feedback above (the limitations as well as fragilities, I decided to re-implement from an alternative approach yesterday, see #1983). This new implementation is also driven by a new requirement for in-place inversion without touching the data. |
Addition to iris.util for convenient inversion of a specified coordinate on a cube or list of cubes.