tests for util.new_axis added pending bugfix#2130
Closed
corinnebosley wants to merge 1 commit intoSciTools:masterfrom
Closed
tests for util.new_axis added pending bugfix#2130corinnebosley wants to merge 1 commit intoSciTools:masterfrom
corinnebosley wants to merge 1 commit intoSciTools:masterfrom
Conversation
Member
Author
|
Have found tests for this function in alternate location, so have relocated them and added them to PR#2143: #2143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iris.util.new_axis() does not work for a MaskedConstant. This is now more of an issue since the change to make iris.util.new_axis() handle lazy data, because it now turns any single-point masked array into a MaskedConstant and then doesn't add a new axis to the mask, only to the data.
For now I have only written tests for this PR; I have not yet added the fix because I don't know what it is.