Merged
Conversation
Merged
lib/iris/pandas.py
Outdated
| base = pandas_obj[0].base | ||
|
|
||
| if pandas_obj.values is np_obj: | ||
| return |
Member
There was a problem hiding this comment.
please add a comment around this change, explaining why the change is needed and referencing pandas versions as appropriate
I would like to see just enough about the pandas implementation change to be able to understand the change if I came back to it
d5d1163 to
aaa8c04
Compare
Member
|
this looks fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue that now the
_assert_sharedfunction can't detect when a pandas object shares its data with a numpy array.I'm not really happy with this solution. There's nothing in the pandas documentation that says
valuesreturns the original data object (indeed, in 0.16.2 it doesn't). But I can't find another way.As an aside, a note in the doctring of
_assert_sharedas_seriesstatesThis doesn't appear to be the case any more. At least,
valuesalways seems to return the original array, and the buffer objects of apandas.Seriesand the NumPy array from which it was created always seem to point to the same location in memory, ifcope=Falseis specified.