Remove AssertString tests from test_pandas.py, replace with in-code tests#2142
Merged
marqh merged 1 commit intoSciTools:masterfrom Sep 15, 2016
Merged
Remove AssertString tests from test_pandas.py, replace with in-code tests#2142marqh merged 1 commit intoSciTools:masterfrom
marqh merged 1 commit intoSciTools:masterfrom
Conversation
Merged
Member
|
i think these test are maintaining test coverage whilst being more explicit about what is being tested in the test code They also remove a fragility, exposed by a change to the pandas version and the way they choose to implement I am very much minded to merge this as is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces uses of assertString in Pandas tests, one of which was failing due to a slight formatting change, with tests on the data.