Fix unit test failing due to change in cf_units#2144
Merged
DPeterK merged 3 commits intoSciTools:v1.10.xfrom Sep 28, 2016
Merged
Fix unit test failing due to change in cf_units#2144DPeterK merged 3 commits intoSciTools:v1.10.xfrom
DPeterK merged 3 commits intoSciTools:v1.10.xfrom
Conversation
Contributor
Author
|
@pelson @dkillick Since there has now been a release of |
Contributor
Author
This was referenced Sep 22, 2016
djkirkham
force-pushed
the
fix-convert-unit-test
branch
from
896660e to
fef06e9
Compare
Member
|
Looks good 👍 |
Merged
This was referenced Sep 28, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A unit test was passing a mock object to
cf_units.date2num, and failing with the changes in SciTools/cf-units#68. This change ensures that actualdatetimeobjects are passed to that function.The unit test in question doesn't care about the values returned by the function, so the datetimes passed are essentially arbitrary.