Fix portability of whatsnew test.#2156
Conversation
Remove unnecessary use of `shell=True`, and use the correct Python interpreter (i.e., the same one that's running the tests.)
|
Hi @QuLogic is there a key reason to target 1.10.x for this? if we do so, are we honour bound to make a 1.10.1 release (not currently planned)? is it reasonable to target master with this change? thank you |
No, if there ends up being a v1.10.1 then it will get the fix which could be helpful, if not then as long as we merge changes from v1.10.x back into master before cutting the next release branch (which we always should) then it will end up on master anyway. |
on that basis I'm happy to accept this as is, perhaps we could merge-back swiftly afterwards, to ensure this is captured? |
Yes, there is no need to wait. |
|
Thanks @QuLogic. 👍 |
Because it's a bug fix and that's the bug fix branch. Just because it's hoped that 1.11 will be the next release, doesn't been it will be. After all, 1.10 took quite a while to eventually come out in shape. |
Remove unnecessary use of
shell=True, and use the correct Python interpreter (i.e., the same one that's running the tests.)