catch setting of coordiantes and bounds for netcdf saver (string typing)#2179
Merged
pelson merged 7 commits intoSciTools:masterfrom Oct 10, 2016
Merged
catch setting of coordiantes and bounds for netcdf saver (string typing)#2179pelson merged 7 commits intoSciTools:masterfrom
pelson merged 7 commits intoSciTools:masterfrom
Conversation
Member
|
Does |
marqh
commented
Oct 10, 2016
conda-requirements.txt
Outdated
| biggus | ||
| cartopy | ||
| matplotlib=1.3.1 | ||
| matplotlib |
Member
Author
There was a problem hiding this comment.
the mpl pin should not be changed in this PR
Member
|
Python3 issue with your unit test: |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix to make #2158 functional for newer netcdf4-python
i am not convinced this catch all potential cases, only the ones we test
a few words prior to merge would be helpful